From: Clemens Ladisch Date: Fri, 22 Feb 2008 17:47:44 +0000 (+0100) Subject: [ALSA] bt87X: fix freeing of shared interrupt X-Git-Tag: v2.6.25-rc3~73 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=2f93d797ea92113a73c72728c475455cb1409fb3;p=linux-2.6-omap-h63xx.git [ALSA] bt87X: fix freeing of shared interrupt Call free_irq() after iounmap() because other devices could trigger our shared interrupt handler. Signed-off-by: Clemens Ladisch Signed-off-by: Takashi Iwai Signed-off-by: Linus Torvalds --- diff --git a/sound/pci/bt87x.c b/sound/pci/bt87x.c index c9a2421cf6f..4ecdd635ed1 100644 --- a/sound/pci/bt87x.c +++ b/sound/pci/bt87x.c @@ -681,15 +681,12 @@ static struct snd_kcontrol_new snd_bt87x_capture_source = { static int snd_bt87x_free(struct snd_bt87x *chip) { - if (chip->mmio) { + if (chip->mmio) snd_bt87x_stop(chip); - if (chip->irq >= 0) - synchronize_irq(chip->irq); - - iounmap(chip->mmio); - } if (chip->irq >= 0) free_irq(chip->irq, chip); + if (chip->mmio) + iounmap(chip->mmio); pci_release_regions(chip->pci); pci_disable_device(chip->pci); kfree(chip);