From: Krishna Kumar <krkumar2@in.ibm.com>
Date: Mon, 20 Oct 2008 06:17:09 +0000 (+0530)
Subject: nfsd: Fix leaked memory in nfs4_make_rec_clidname
X-Git-Tag: v2.6.29-rc1~177^2~64
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=2bd9e7b62e6e1da3f881c40c73d93e9a212ce6de;p=linux-2.6-omap-h63xx.git

nfsd: Fix leaked memory in nfs4_make_rec_clidname

cksum.data is not freed up in one error case. Compile tested.

Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
---

diff --git a/fs/nfsd/nfs4recover.c b/fs/nfsd/nfs4recover.c
index 0f9d6efaa62..74f7b67567f 100644
--- a/fs/nfsd/nfs4recover.c
+++ b/fs/nfsd/nfs4recover.c
@@ -116,9 +116,9 @@ nfs4_make_rec_clidname(char *dname, struct xdr_netobj *clname)
 
 	md5_to_hex(dname, cksum.data);
 
-	kfree(cksum.data);
 	status = nfs_ok;
 out:
+	kfree(cksum.data);
 	crypto_free_hash(desc.tfm);
 out_no_tfm:
 	return status;