From: Hannes Eder <hannes@hanneseder.net>
Date: Tue, 18 Nov 2008 17:25:06 +0000 (-0500)
Subject: sound: Fix warnings relating to ignored return value in snd_card_register
X-Git-Tag: v2.6.29-rc1~590^2^2
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=2af752936b311a846622668f8b0f1893d8eccade;p=linux-2.6-omap-h63xx.git

sound: Fix warnings relating to ignored return value in snd_card_register

Do not ignore the return of 'device_create_file' in
'snd_card_register' and thereby fixing the following warnings:

sound/core/init.c: In function 'snd_card_register':
sound/core/init.c:640: warning: ignoring return value of
'device_create_file', declared with attribute warn_unused_result
sound/core/init.c:641: warning: ignoring return value of
'device_create_file', declared with attribute warn_unused_result

Signed-off-by: Hannes Eder <hannes@hanneseder.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/sound/core/init.c b/sound/core/init.c
index af1e407ca27..0d5520c415d 100644
--- a/sound/core/init.c
+++ b/sound/core/init.c
@@ -637,8 +637,12 @@ int snd_card_register(struct snd_card *card)
 #endif
 #ifndef CONFIG_SYSFS_DEPRECATED
 	if (card->card_dev) {
-		device_create_file(card->card_dev, &card_id_attrs);
-		device_create_file(card->card_dev, &card_number_attrs);
+		err = device_create_file(card->card_dev, &card_id_attrs);
+		if (err < 0)
+			return err;
+		err = device_create_file(card->card_dev, &card_number_attrs);
+		if (err < 0)
+			return err;
 	}
 #endif
 	return 0;