From: Andi Kleen Date: Thu, 16 Feb 2006 22:42:16 +0000 (+0100) Subject: [PATCH] x86_64: Always pass full number of nodes to NUMA hash computation X-Git-Tag: v2.6.16-rc4~31 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=2aed711a399cbc4a9bf239c13f05a8a8b460f215;p=linux-2.6-omap-h63xx.git [PATCH] x86_64: Always pass full number of nodes to NUMA hash computation Previously the numa hash code would be confused by holes in the node space and stop early. This is the first part of the fix for the non boot issue with empty nodes on Opterons. Signed-off-by: Andi Kleen Signed-off-by: Linus Torvalds --- diff --git a/arch/x86_64/mm/k8topology.c b/arch/x86_64/mm/k8topology.c index a5663e0bb01..dd60e71fdba 100644 --- a/arch/x86_64/mm/k8topology.c +++ b/arch/x86_64/mm/k8topology.c @@ -155,7 +155,7 @@ int __init k8_scan_nodes(unsigned long start, unsigned long end) if (!found) return -1; - memnode_shift = compute_hash_shift(nodes, numnodes); + memnode_shift = compute_hash_shift(nodes, 8); if (memnode_shift < 0) { printk(KERN_ERR "No NUMA node hash function found. Contact maintainer\n"); return -1; diff --git a/arch/x86_64/mm/srat.c b/arch/x86_64/mm/srat.c index 809dc70675f..482c2576736 100644 --- a/arch/x86_64/mm/srat.c +++ b/arch/x86_64/mm/srat.c @@ -271,7 +271,7 @@ int __init acpi_scan_nodes(unsigned long start, unsigned long end) return -1; } - memnode_shift = compute_hash_shift(nodes, nodes_weight(nodes_parsed)); + memnode_shift = compute_hash_shift(nodes, MAX_NUMNODES); if (memnode_shift < 0) { printk(KERN_ERR "SRAT: No NUMA node hash function found. Contact maintainer\n");