From: Gabriel A. Devenyi Date: Fri, 4 Nov 2005 00:30:47 +0000 (-0500) Subject: [PATCH] drivers/net/wireless/airo.c unsigned comparason X-Git-Tag: v2.6.15-rc1~721^2~6 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=29b09fcc341ede8dc08c900b132903fdd0231400;p=linux-2.6-omap-h63xx.git [PATCH] drivers/net/wireless/airo.c unsigned comparason fid is declared as a u32 (unsigned int), and then a few lines later, it is checked for a value < 0, which is clearly useless. In the two locations this function is used, in one it is *explicitly* given a negative number, which would be ignored with the current definition. Thanks to LinuxICC (http://linuxicc.sf.net). Signed-off-by: Gabriel A. Devenyi Signed-off-by: Jeff Garzik --- diff --git a/drivers/net/wireless/airo.c b/drivers/net/wireless/airo.c index 750c0167539..849ac88bccc 100644 --- a/drivers/net/wireless/airo.c +++ b/drivers/net/wireless/airo.c @@ -2040,7 +2040,7 @@ static int mpi_send_packet (struct net_device *dev) return 1; } -static void get_tx_error(struct airo_info *ai, u32 fid) +static void get_tx_error(struct airo_info *ai, s32 fid) { u16 status;