From: Paul Fulghum <paulkf@microgate.com>
Date: Sun, 25 Jun 2006 12:49:21 +0000 (-0700)
Subject: [PATCH] fix synclink_gt diagnostics error reporting
X-Git-Tag: v2.6.18-rc1~879
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=294dad05311416718c2a172738e1ca4071449877;p=linux-2.6-omap-h63xx.git

[PATCH] fix synclink_gt diagnostics error reporting

Fix diagnostics error reporting that was being overwritten by incorrect use
of return codes from individual diagnostic functions.

Signed-off-by: Paul Fulghum <paulkf@microgate.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
---

diff --git a/drivers/char/synclink_gt.c b/drivers/char/synclink_gt.c
index 03a7f20db49..41eab9831ad 100644
--- a/drivers/char/synclink_gt.c
+++ b/drivers/char/synclink_gt.c
@@ -4702,13 +4702,13 @@ static int loopback_test(struct slgt_info *info)
 static int adapter_test(struct slgt_info *info)
 {
 	DBGINFO(("testing %s\n", info->device_name));
-	if ((info->init_error = register_test(info)) < 0) {
+	if (register_test(info) < 0) {
 		printk("register test failure %s addr=%08X\n",
 			info->device_name, info->phys_reg_addr);
-	} else if ((info->init_error = irq_test(info)) < 0) {
+	} else if (irq_test(info) < 0) {
 		printk("IRQ test failure %s IRQ=%d\n",
 			info->device_name, info->irq_level);
-	} else if ((info->init_error = loopback_test(info)) < 0) {
+	} else if (loopback_test(info) < 0) {
 		printk("loopback test failure %s\n", info->device_name);
 	}
 	return info->init_error;