From: Al Viro Date: Thu, 4 Dec 2008 14:57:25 +0000 (-0500) Subject: isofs check for NULL ->i_op in root directory is dead code X-Git-Tag: v2.6.29-rc1~506^2~9 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=261964c60ff6524076d439da9386d4782729c4d9;p=linux-2.6-omap-h63xx.git isofs check for NULL ->i_op in root directory is dead code for one thing it never happens, for another we check that inode is a directory right after that place anyway (and we'd already checked that reading it from disk has not failed). Signed-off-by: Al Viro --- diff --git a/fs/isofs/inode.c b/fs/isofs/inode.c index 3f8af0f1505..6147ec3643a 100644 --- a/fs/isofs/inode.c +++ b/fs/isofs/inode.c @@ -855,10 +855,6 @@ root_found: } sbi->s_joliet_level = joliet_level; - /* check the root inode */ - if (!inode->i_op) - goto out_bad_root; - /* Make sure the root inode is a directory */ if (!S_ISDIR(inode->i_mode)) { printk(KERN_WARNING @@ -886,8 +882,6 @@ root_found: /* * Display error messages and free resources. */ -out_bad_root: - printk(KERN_WARNING "%s: root inode not initialized\n", __func__); out_iput: iput(inode); goto out_no_inode;