From: Alan Cox Date: Sun, 11 Jan 2009 19:48:34 +0000 (+0000) Subject: neo: Remove a bogus NULL check X-Git-Tag: v2.6.29-rc2~99 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=21b56ec4e96f2bd8c584db41bd9a42c6cb71fdac;p=linux-2.6-omap-h63xx.git neo: Remove a bogus NULL check Julia Lawall found an un-needed check in the neo driver. Her patch moves the check to cover the code dereferencing it, however it cannot be NULL anyway so remove the NULL check instead. Signed-off-by: Alan Cox Signed-off-by: Linus Torvalds --- diff --git a/drivers/serial/jsm/jsm_neo.c b/drivers/serial/jsm/jsm_neo.c index b7584ca55ad..e6390d02363 100644 --- a/drivers/serial/jsm/jsm_neo.c +++ b/drivers/serial/jsm/jsm_neo.c @@ -577,9 +577,6 @@ static void neo_parse_modem(struct jsm_channel *ch, u8 signals) jsm_printk(MSIGS, INFO, &ch->ch_bd->pci_dev, "neo_parse_modem: port: %d msignals: %x\n", ch->ch_portnum, msignals); - if (!ch) - return; - /* Scrub off lower bits. They signify delta's, which I don't care about */ /* Keep DDCD and DDSR though */ msignals &= 0xf8;