From: Tejun Heo Date: Tue, 25 Mar 2008 13:16:39 +0000 (+0900) Subject: libata: drop ata_dev_select() from ata_dev_read_id X-Git-Tag: v2.6.26-rc1~1150^2~63 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=21572ea58a1f99a59044febde90c31167d2f59ae;p=linux-2.6-omap-h63xx.git libata: drop ata_dev_select() from ata_dev_read_id There is no reason to issue device select in read_id, it will be done by ops->qc_issue() when IDENTIFY[_PACKET] is issued via ata_exec_internal(). Signed-off-by: Tejun Heo Signed-off-by: Jeff Garzik --- diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 345f4a6865a..7860d9f60ae 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -2156,7 +2156,6 @@ int ata_dev_read_id(struct ata_device *dev, unsigned int *p_class, if (ata_msg_ctl(ap)) ata_dev_printk(dev, KERN_DEBUG, "%s: ENTER\n", __func__); - ata_dev_select(ap, dev->devno, 1, 1); /* select device 0/1 */ retry: ata_tf_init(dev, &tf);