From: Milton Miller <miltonm@bga.com>
Date: Thu, 8 Jan 2009 02:19:43 +0000 (+0000)
Subject: powerpc/numa: Avoid possible reference beyond prop. length in find_min_common_depth()
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=20fcefe5a0a354b0cc78ec4634d9f72dab5f1ee9;p=linux-2.6-omap-h63xx.git

powerpc/numa: Avoid possible reference beyond prop. length in find_min_common_depth()

find_min_common_depth() was checking the property length incorrectly.
The value is in bytes not cells, and it is using the second entry.

Signed-off-By: Milton Miller <miltonm@bga.com>

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---

diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
index 7393bd76d69..e26d5e5c22b 100644
--- a/arch/powerpc/mm/numa.c
+++ b/arch/powerpc/mm/numa.c
@@ -289,7 +289,7 @@ static int __init find_min_common_depth(void)
 	ref_points = of_get_property(rtas_root,
 			"ibm,associativity-reference-points", &len);
 
-	if ((len >= 1) && ref_points) {
+	if ((len >= 2 * sizeof(unsigned int)) && ref_points) {
 		depth = ref_points[1];
 	} else {
 		dbg("NUMA: ibm,associativity-reference-points not found.\n");