From: Neil Brown Date: Thu, 12 Jan 2006 09:05:23 +0000 (-0800) Subject: [PATCH] md: remove slashes from disk names when creation dev names in sysfs X-Git-Tag: v2.6.16-rc1~279 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=1edf80d347387405ff4e8934d194d75f57a3caef;p=linux-2.6-omap-h63xx.git [PATCH] md: remove slashes from disk names when creation dev names in sysfs e.g. The sx8 driver uses names like sx8/0. This would make a md component dev name like /sys/block/md0/md/dev-sx8/0 which is not allowed. So we change the '/' to '!' just like fs/partitions/check.c(register_disk) does. Signed-off-by: Neil Brown Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/drivers/md/md.c b/drivers/md/md.c index 0302723fa21..1778104e106 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -1238,6 +1238,7 @@ static int bind_rdev_to_array(mdk_rdev_t * rdev, mddev_t * mddev) mdk_rdev_t *same_pdev; char b[BDEVNAME_SIZE], b2[BDEVNAME_SIZE]; struct kobject *ko; + char *s; if (rdev->mddev) { MD_BUG(); @@ -1277,6 +1278,8 @@ static int bind_rdev_to_array(mdk_rdev_t * rdev, mddev_t * mddev) bdevname(rdev->bdev,b); if (kobject_set_name(&rdev->kobj, "dev-%s", b) < 0) return -ENOMEM; + while ( (s=strchr(rdev->kobj.k_name, '/')) != NULL) + *s = '!'; list_add(&rdev->same_set, &mddev->disks); rdev->mddev = mddev;