From: Matt Fleming Date: Sun, 2 Nov 2008 16:04:18 +0000 (+0000) Subject: x86: HPET: convert WARN_ON to WARN_ON_ONCE X-Git-Tag: v2.6.28-rc5~78^2~5 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=1de5b0854623d30d01d72cd4ea323eb5f39d1f16;p=linux-2.6-omap-h63xx.git x86: HPET: convert WARN_ON to WARN_ON_ONCE It is possible to flood the console with call traces if the WARN_ON condition is true because of the frequency with which this function is called. Signed-off-by: Matt Fleming Cc: mingo@elte.hu Cc: venkatesh.pallipadi@intel.com Signed-off-by: Thomas Gleixner --- diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c index 77017e834cf..f10f9461a43 100644 --- a/arch/x86/kernel/hpet.c +++ b/arch/x86/kernel/hpet.c @@ -322,7 +322,7 @@ static int hpet_next_event(unsigned long delta, * what we wrote hit the chip before we compare it to the * counter. */ - WARN_ON((u32)hpet_readl(HPET_T0_CMP) != cnt); + WARN_ON_ONCE((u32)hpet_readl(HPET_T0_CMP) != cnt); return (s32)((u32)hpet_readl(HPET_COUNTER) - cnt) >= 0 ? -ETIME : 0; }