From: Li Zefan Date: Fri, 13 Jun 2008 03:09:16 +0000 (+0800) Subject: kobject: should use kobject_put() in kset-example X-Git-Tag: v2.6.27-rc1~866^2~18 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=185000fc556372b7fb7f26516c325f212030dbd3;p=linux-2.6-omap-h63xx.git kobject: should use kobject_put() in kset-example We should call kobject_put() instead of kfree() if kobject_init_and_add() returns an error, shouldn't we? Don't set up a bad example ;) Signed-off-by: Li Zefan Signed-off-by: Greg Kroah-Hartman --- diff --git a/samples/kobject/kset-example.c b/samples/kobject/kset-example.c index b0a1b4fe658..7395c0bbae1 100644 --- a/samples/kobject/kset-example.c +++ b/samples/kobject/kset-example.c @@ -211,7 +211,7 @@ static struct foo_obj *create_foo_obj(const char *name) */ retval = kobject_init_and_add(&foo->kobj, &foo_ktype, NULL, "%s", name); if (retval) { - kfree(foo); + kobject_put(&foo->kobj); return NULL; }