From: Greg Kroah-Hartman <gregkh@suse.de>
Date: Thu, 18 May 2006 17:39:21 +0000 (-0700)
Subject: [PATCH] kobject: make people pay attention to kobject_add errors
X-Git-Tag: v2.6.18-rc1~858^2~134
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=183bd5b3da82b80920c30c4772222df8027fc364;p=linux-2.6-omap-h63xx.git

[PATCH] kobject: make people pay attention to kobject_add errors

These really need to be fixed, shout it out to the world.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/lib/kobject.c b/lib/kobject.c
index 687ab418d29..8e7c7199348 100644
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@ -198,14 +198,14 @@ int kobject_add(struct kobject * kobj)
 
 		/* be noisy on error issues */
 		if (error == -EEXIST)
-			pr_debug("kobject_add failed for %s with -EEXIST, "
+			printk("kobject_add failed for %s with -EEXIST, "
 			       "don't try to register things with the "
 			       "same name in the same directory.\n",
 			       kobject_name(kobj));
 		else
-			pr_debug("kobject_add failed for %s (%d)\n",
+			printk("kobject_add failed for %s (%d)\n",
 			       kobject_name(kobj), error);
-		/* dump_stack(); */
+		 dump_stack();
 	}
 
 	return error;