From: vignesh babu Date: Thu, 13 Dec 2007 18:43:41 +0000 (-0600) Subject: [SCSI] libiscsi: use is_power_of_2 X-Git-Tag: v2.6.25-rc1~1230^2~93 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=118365721768f29d74718a59895ed7bd3c10b68e;p=linux-2.6-omap-h63xx.git [SCSI] libiscsi: use is_power_of_2 Replacing n & (n - 1) for power of 2 check by is_power_of_2(n) Signed-off-by: vignesh babu Signed-off-by: Mike Christie Signed-off-by: James Bottomley --- diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c index 6573223cb34..553168ae44f 100644 --- a/drivers/scsi/libiscsi.c +++ b/drivers/scsi/libiscsi.c @@ -24,6 +24,7 @@ #include #include #include +#include #include #include #include @@ -1700,7 +1701,7 @@ iscsi_session_setup(struct iscsi_transport *iscsit, qdepth = ISCSI_DEF_CMD_PER_LUN; } - if (cmds_max < 2 || (cmds_max & (cmds_max - 1)) || + if (!is_power_of_2(cmds_max) || cmds_max >= ISCSI_MGMT_ITT_OFFSET) { if (cmds_max != 0) printk(KERN_ERR "iscsi: invalid can_queue of %d. "