From: Mark Fasheh Date: Fri, 29 Feb 2008 01:16:03 +0000 (-0800) Subject: ocfs2: Fix writeout in ocfs2_data_convert_worker() X-Git-Tag: v2.6.25-rc4~93^2~5 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=1044e401af9a309637828aa3cc8f3b6409fcbf4e;p=linux-2.6-omap-h63xx.git ocfs2: Fix writeout in ocfs2_data_convert_worker() Commit f1f540688eae66c274ff1c1133b5d9c687b28f58 "optimized" ocfs2_data_convert_worker() to "only do work for regular files". Unfortunately, I left out a '!', which casued it to *skip* regular files. This was hidden from testing until recently because the default data journaling mode (data=ordered) doesn't exercise this code. Signed-off-by: Mark Fasheh Signed-off-by: Joel Becker --- diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c index 351130c9b73..f4b3dab8699 100644 --- a/fs/ocfs2/dlmglue.c +++ b/fs/ocfs2/dlmglue.c @@ -3042,7 +3042,7 @@ static int ocfs2_data_convert_worker(struct ocfs2_lock_res *lockres, inode = ocfs2_lock_res_inode(lockres); mapping = inode->i_mapping; - if (S_ISREG(inode->i_mode)) + if (!S_ISREG(inode->i_mode)) goto out; /*