From: Ben Hutchings <bhutchings@solarflare.com>
Date: Sat, 13 Dec 2008 06:08:50 +0000 (-0800)
Subject: sfc: Use kzalloc() to ensure struct efx_spi_device is fully initialised
X-Git-Tag: v2.6.29-rc1~581^2~206
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=0c53d8c84047d86169bd4147bb8f5adf2772d2bb;p=linux-2.6-omap-h63xx.git

sfc: Use kzalloc() to ensure struct efx_spi_device is fully initialised

Currently the mtd field is not initialised early enough.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/sfc/falcon.c b/drivers/net/sfc/falcon.c
index df844defc0a..6884dc8c1f8 100644
--- a/drivers/net/sfc/falcon.c
+++ b/drivers/net/sfc/falcon.c
@@ -2690,7 +2690,7 @@ static int falcon_spi_device_init(struct efx_nic *efx,
 	struct efx_spi_device *spi_device;
 
 	if (device_type != 0) {
-		spi_device = kmalloc(sizeof(*spi_device), GFP_KERNEL);
+		spi_device = kzalloc(sizeof(*spi_device), GFP_KERNEL);
 		if (!spi_device)
 			return -ENOMEM;
 		spi_device->device_id = device_id;