From: Jon Smirl <jonsmirl@gmail.com>
Date: Mon, 20 Oct 2008 02:13:15 +0000 (+0000)
Subject: of: Format string bug in drivers/of/of_i2c.c
X-Git-Tag: v2.6.28-rc1~58^2~20
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=0721357d4d04563b6e5c7ffd6b5685df275d5ff9;p=linux-2.6-omap-h63xx.git

of: Format string bug in drivers/of/of_i2c.c

Format string bug.  Not exploitable, as this is only writable by root,
but worth fixing all the same.

See 326f6a5c9c9e1a62aec37bdc0c3f8d53adabe77b

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---

diff --git a/drivers/of/of_i2c.c b/drivers/of/of_i2c.c
index 6a98dc8aa30..24bbef777c1 100644
--- a/drivers/of/of_i2c.c
+++ b/drivers/of/of_i2c.c
@@ -41,7 +41,7 @@ void of_register_i2c_devices(struct i2c_adapter *adap,
 
 		info.addr = *addr;
 
-		request_module(info.type);
+		request_module("%s", info.type);
 
 		result = i2c_new_device(adap, &info);
 		if (result == NULL) {