From: Erik Mouw Date: Mon, 4 Feb 2008 17:56:54 +0000 (+0100) Subject: xircom_cb should return NETDEV_TX_BUSY when no descriptors available X-Git-Tag: v2.6.25-rc1~518^2^2~16 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=06f7525be463ef95bfdba001484bda04d00ec74e;p=linux-2.6-omap-h63xx.git xircom_cb should return NETDEV_TX_BUSY when no descriptors available Changes in other networking paths uncovered a bug in the xircom_cb driver which made the kernel spew lots of the following error messages: BUG eth1 code -5 qlen 0 It turned out that the driver returned -EIO when there was no descriptor available for sending packets. It should return NETDEV_TX_BUSY instead. This was discussed on the netdev list before, see http://thread.gmane.org/gmane.linux.network/84603 . Signed-off-by: Erik Mouw Signed-off-by: Jeff Garzik --- diff --git a/drivers/net/tulip/xircom_cb.c b/drivers/net/tulip/xircom_cb.c index 8fc7274642e..6b93d016911 100644 --- a/drivers/net/tulip/xircom_cb.c +++ b/drivers/net/tulip/xircom_cb.c @@ -441,7 +441,7 @@ static int xircom_start_xmit(struct sk_buff *skb, struct net_device *dev) spin_unlock_irqrestore(&card->lock,flags); trigger_transmit(card); - return -EIO; + return NETDEV_TX_BUSY; }