From: WANG Cong <wcong@critical-links.com>
Date: Sat, 28 Jun 2008 02:51:35 +0000 (-0700)
Subject: pkt_sched: ERR_PTR() ususally encodes an negative errno, not positive.
X-Git-Tag: v2.6.26-rc9~84^2~19
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=01e123d79a23000f85c4cfb12a957908c0b2c3d8;p=linux-2.6-omap-h63xx.git

pkt_sched: ERR_PTR() ususally encodes an negative errno, not positive.

Note, in the following patch, 'err' is initialized as:

int err = -ENOBUFS;

Signed-off-by: WANG Cong <wcong@critical-links.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c
index d355e5e47fe..13afa721439 100644
--- a/net/sched/sch_generic.c
+++ b/net/sched/sch_generic.c
@@ -468,7 +468,7 @@ struct Qdisc *qdisc_alloc(struct net_device *dev, struct Qdisc_ops *ops)
 
 	return sch;
 errout:
-	return ERR_PTR(-err);
+	return ERR_PTR(err);
 }
 
 struct Qdisc * qdisc_create_dflt(struct net_device *dev, struct Qdisc_ops *ops,