]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
mac80211: filter scan results on unusable channels
authorJohannes Berg <johannes@sipsolutions.net>
Sun, 16 Mar 2008 17:42:44 +0000 (18:42 +0100)
committerJohn W. Linville <linville@tuxdriver.com>
Tue, 25 Mar 2008 20:41:56 +0000 (16:41 -0400)
When you have an AP on channel 13, it will currently often enough
be listed in scan results even when the regulatory domain restricts
to channels 1-11. This is due to channel overlap. To avoid getting
very strange failures, don't show such APs in the scan results. The
failure mode will now go from "I can see the AP but not associate"
to "I can't see the AP although I know it's there" which is easier
to debug.

This problem was first really noticed by Jes Sorensen.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Cc: Jes Sorensen <jes@trained-monkey.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
net/mac80211/ieee80211_sta.c

index 8b991ebcbb4ed7b682fd1dbad4663d3a6ca3c466..86da69f443847d6b6d459115c7427c5f7ce961e0 100644 (file)
@@ -2356,6 +2356,7 @@ static void ieee80211_rx_bss_info(struct net_device *dev,
        struct sta_info *sta;
        struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev);
        u64 beacon_timestamp, rx_timestamp;
+       struct ieee80211_channel *channel;
        DECLARE_MAC_BUF(mac);
        DECLARE_MAC_BUF(mac2);
 
@@ -2420,6 +2421,11 @@ static void ieee80211_rx_bss_info(struct net_device *dev,
        else
                freq = rx_status->freq;
 
+       channel = ieee80211_get_channel(local->hw.wiphy, freq);
+
+       if (!channel || channel->flags & IEEE80211_CHAN_DISABLED)
+               return;
+
 #ifdef CONFIG_MAC80211_MESH
        if (elems.mesh_config)
                bss = ieee80211_rx_mesh_bss_get(dev, elems.mesh_id,