]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
ide: fix drive side 80c cable check, take 2
authorTejun Heo <htejun@gmail.com>
Sat, 3 Mar 2007 16:48:53 +0000 (17:48 +0100)
committerBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Sat, 3 Mar 2007 16:48:53 +0000 (17:48 +0100)
eighty_ninty_three() had word 93 validitity check but not the 80c bit
test itself (bit 13).  This increases the chance of incorrect wire
detection especially because host side cable detection is often
unreliable and we sometimes soley depend on drive side cable
detection.  Fix it.

[ bart: fix off-by-1 bit name in the patch description ]

Signed-off-by: Tejun Heo <htejun@gmail.com>
Acked-by: Alan Cox <alan@redhat.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
drivers/ide/ide-iops.c

index c67b3b1e6f4c64b255d043220a8cdc8b72aff80b..bd513f5a23236166541946391aab8239985201c9 100644 (file)
@@ -583,6 +583,8 @@ u8 eighty_ninty_three (ide_drive_t *drive)
        if(!(drive->id->hw_config & 0x4000))
                return 0;
 #endif /* CONFIG_IDEDMA_IVB */
+       if (!(drive->id->hw_config & 0x2000))
+               return 0;
        return 1;
 }