]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
ath5k: Don't call reset on config_interface
authorNick Kossifidis <mick@madwifi-project.org>
Mon, 9 Feb 2009 04:17:45 +0000 (06:17 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Fri, 13 Feb 2009 18:44:52 +0000 (13:44 -0500)
 * We call reset too often and this can result various PHY problems.
  On config_interface we don't need to reset the whole device.

  TODO: Create a function hw_fast_reset that only resets the PCU
  (tx/rx stuff) and not the whole device so that we can use this for
  stuck beacons etc.

Signed-off-by: Nick Kossifidis <mickflemm@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/ath5k/base.c

index 3d36e84b1e057b1b336acf8d051806cab99f1bd5..6837ca9f3831ab3bc2af2859a8687eddc1c6cf02 100644 (file)
@@ -2884,7 +2884,7 @@ ath5k_config_interface(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
 {
        struct ath5k_softc *sc = hw->priv;
        struct ath5k_hw *ah = sc->ah;
-       int ret;
+       int ret = 0;
 
        mutex_lock(&sc->lock);
        if (sc->vif != vif) {
@@ -2910,9 +2910,7 @@ ath5k_config_interface(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
                }
                ath5k_beacon_update(sc, beacon);
        }
-       mutex_unlock(&sc->lock);
 
-       return ath5k_reset_wake(sc);
 unlock:
        mutex_unlock(&sc->lock);
        return ret;