]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
libata passthru: always enforce correct DEV bit
authorAlbert Lee <albertcc@tw.ibm.com>
Thu, 7 Jun 2007 07:52:07 +0000 (15:52 +0800)
committerJeff Garzik <jeff@garzik.org>
Sun, 10 Jun 2007 03:08:12 +0000 (23:08 -0400)
 Always enforce correct DEV bit since we know which drive the command
is targeted. SAT demands to ignore the DEV bit, too.

Signed-off-by: Albert Lee <albertcc@tw.ibm.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/ata/libata-scsi.c

index 8c6a2b2e81b438c4ecb88a7ca21eb4f2bbdd481c..884f52f43f8f38b31d63ca2a23750c514f0427c7 100644 (file)
@@ -2595,12 +2595,10 @@ static unsigned int ata_scsi_pass_thru(struct ata_queued_cmd *qc)
                tf->device = cdb[8];
                tf->command = cdb[9];
        }
-       /*
-        * If slave is possible, enforce correct master/slave bit
-       */
-       if (qc->ap->flags & ATA_FLAG_SLAVE_POSS)
-               tf->device = qc->dev->devno ?
-                       tf->device | ATA_DEV1 : tf->device & ~ATA_DEV1;
+
+       /* enforce correct master/slave bit */
+       tf->device = dev->devno ?
+               tf->device | ATA_DEV1 : tf->device & ~ATA_DEV1;
 
        /* sanity check for pio multi commands */
        if ((cdb[1] & 0xe0) && !is_multi_taskfile(tf))