]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[PKT_SCHED]: Fix datalen check in tcf_simp_init().
authorPatrick McHardy <kaber@trash.net>
Fri, 18 Apr 2008 06:19:55 +0000 (23:19 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 18 Apr 2008 06:19:55 +0000 (23:19 -0700)
datalen is unsigned so it can never be less than zero,
but that's ok because the attribute passed to nla_len()
has been validated and therefore a negative return
value is impossible.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/act_simple.c

index fbde461b716cc90dc8de261870078ed7c42b8703..64b2d136c78e9ac1cf370e3289bed361de9995ff 100644 (file)
@@ -115,7 +115,7 @@ static int tcf_simp_init(struct nlattr *nla, struct nlattr *est,
                return -EINVAL;
 
        datalen = nla_len(tb[TCA_DEF_DATA]);
-       if (datalen <= 0)
+       if (datalen == 0)
                return -EINVAL;
 
        pc = tcf_hash_check(parm->index, a, bind, &simp_hash_info);