]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
USB: ark3116.c: fix check-after-use
authorAdrian Bunk <bunk@kernel.org>
Tue, 14 Aug 2007 21:22:50 +0000 (23:22 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 12 Oct 2007 21:55:16 +0000 (14:55 -0700)
The Coverity checker spotted that we'd have already oops'ed if one of
these was NULL.

Signed-off-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/serial/ark3116.c

index c9fd486c1c7d7a030b9d5b039caabe2a9f3f5c56..2a8e537cb046eb77a7bcc77a60679d7d716a96cf 100644 (file)
@@ -172,11 +172,6 @@ static void ark3116_set_termios(struct usb_serial_port *port,
 
        dbg("%s - port %d", __FUNCTION__, port->number);
 
-       if (!port->tty || !port->tty->termios) {
-               dbg("%s - no tty structures", __FUNCTION__);
-               return;
-       }
-
        spin_lock_irqsave(&priv->lock, flags);
        if (!priv->termios_initialized) {
                *(port->tty->termios) = tty_std_termios;