]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[ARM] cumana: Fix a long standing bogon
authorAlan Cox <alan@lxorguk.ukuu.org.uk>
Mon, 23 Mar 2009 10:37:57 +0000 (10:37 +0000)
committerRussell King <rmk+kernel@arm.linux.org.uk>
Tue, 24 Mar 2009 22:52:27 +0000 (22:52 +0000)
Should be using strncmp as the data from user space may be unterminated

(Bug #8004)

Signed-off-by: Alan Cox <alan@lxorguk.ukuu.org.uk
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
drivers/scsi/arm/cumana_2.c

index 68a64123af8f9fd28379a640d7a00b4f6ddcdd39..ed502b7412d69f8bc8adbc3d62ca99678cb83eb0 100644 (file)
@@ -318,7 +318,7 @@ cumanascsi_2_set_proc_info(struct Scsi_Host *host, char *buffer, int length)
 {
        int ret = length;
 
-       if (length >= 11 && strcmp(buffer, "CUMANASCSI2") == 0) {
+       if (length >= 11 && strncmp(buffer, "CUMANASCSI2", 11) == 0) {
                buffer += 11;
                length -= 11;