]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[PATCH] Char: mxser_new, don't check tty_unregister retval
authorJiri Slaby <jirislaby@gmail.com>
Fri, 8 Dec 2006 10:38:26 +0000 (02:38 -0800)
committerLinus Torvalds <torvalds@woody.osdl.org>
Fri, 8 Dec 2006 16:28:54 +0000 (08:28 -0800)
Like other drivers silently unregister_tty_driver and put_tty_driver.  It
shouldn't be busy when module release function is called, since we are not
bsd, no refs shouldn't be held.

Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/char/mxser_new.c

index 7da717730ac74c8828d1d26480644a79f6cb1796..47af0bba5240d316a25ecacfbfa8f219512957df 100644 (file)
@@ -2994,15 +2994,12 @@ static int __init mxser_module_init(void)
 
 static void __exit mxser_module_exit(void)
 {
-       int i, err;
+       unsigned int i;
 
        pr_debug("Unloading module mxser ...\n");
 
-       err = tty_unregister_driver(mxvar_sdriver);
-       if (!err)
-               put_tty_driver(mxvar_sdriver);
-       else
-               printk(KERN_ERR "Couldn't unregister MOXA Smartio/Industio family serial driver\n");
+       tty_unregister_driver(mxvar_sdriver);
+       put_tty_driver(mxvar_sdriver);
 
        for (i = 0; i < MXSER_BOARDS; i++)
                if (mxser_boards[i].board_type != -1)