]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
sparc64: Fix IPI call locking.
authorDavid S. Miller <davem@davemloft.net>
Wed, 3 Sep 2008 09:14:39 +0000 (02:14 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 3 Sep 2008 09:14:39 +0000 (02:14 -0700)
When I switched sparc64 over to the generic helpers for
smp_call_function(), I didn't convert the dinky call_lock
we had.

Use ipi_call_lock() and ipi_call_unlock().

Signed-off-by: David S. Miller <davem@davemloft.net>
arch/sparc64/kernel/smp.c

index 743ccad61c60921b36c9bf42a556dac79ac4e23c..0712a445f98e181f4f4fa4e2fb1f57f52cb35c03 100644 (file)
@@ -80,8 +80,6 @@ void smp_bogo(struct seq_file *m)
                           i, cpu_data(i).clock_tick);
 }
 
-static __cacheline_aligned_in_smp DEFINE_SPINLOCK(call_lock);
-
 extern void setup_sparc64_timer(void);
 
 static volatile unsigned long callin_flag = 0;
@@ -120,9 +118,9 @@ void __cpuinit smp_callin(void)
        while (!cpu_isset(cpuid, smp_commenced_mask))
                rmb();
 
-       spin_lock(&call_lock);
+       ipi_call_lock();
        cpu_set(cpuid, cpu_online_map);
-       spin_unlock(&call_lock);
+       ipi_call_unlock();
 
        /* idle thread is expected to have preempt disabled */
        preempt_disable();
@@ -1305,9 +1303,9 @@ int __cpu_disable(void)
        c->core_id = 0;
        c->proc_id = -1;
 
-       spin_lock(&call_lock);
+       ipi_call_lock();
        cpu_clear(cpu, cpu_online_map);
-       spin_unlock(&call_lock);
+       ipi_call_unlock();
 
        smp_wmb();