]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
PCI hotplug: fix error path in pci_slot's register_slot
authorAlex Chiang <achiang@hp.com>
Thu, 17 Jul 2008 17:13:32 +0000 (11:13 -0600)
committerJesse Barnes <jbarnes@virtuousgeek.org>
Tue, 22 Jul 2008 18:18:17 +0000 (11:18 -0700)
Juha Leppnen noticed that an error path in register_slot() wasn't
returning appropriately, leading to a condition where we might access a
kfree'ed pointer, so let's fix that.

Additionally, fix up the copyright information in the file while
we're in there.

Signed-off-by: Alex Chiang <achiang@hp.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
drivers/acpi/pci_slot.c

index b9ab030a52d50843b0319fb25875f7c965b72ce0..dd376f7ad090706e6deedd1426b3dfdbc9dfd617 100644 (file)
@@ -6,8 +6,8 @@
  *  Thanks to Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com> for code
  *  review and fixes.
  *
- *  Copyright (C) 2007 Alex Chiang <achiang@hp.com>
- *  Copyright (C) 2007 Hewlett-Packard Development Company, L.P.
+ *  Copyright (C) 2007-2008 Hewlett-Packard Development Company, L.P.
+ *     Alex Chiang <achiang@hp.com>
  *
  *  This program is free software; you can redistribute it and/or modify it
  *  under the terms and conditions of the GNU General Public License,
@@ -158,6 +158,7 @@ register_slot(acpi_handle handle, u32 lvl, void *context, void **rv)
        if (IS_ERR(pci_slot)) {
                err("pci_create_slot returned %ld\n", PTR_ERR(pci_slot));
                kfree(slot);
+               return AE_OK;
        }
 
        slot->root_handle = parent_context->root_handle;