]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
cr_backlight_probe() allocates too little storage for struct cr_panel
authorJesper Juhl <jesper.juhl@gmail.com>
Fri, 20 Jul 2007 07:31:47 +0000 (00:31 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Fri, 20 Jul 2007 15:44:20 +0000 (08:44 -0700)
The Coverity checker noticed that we allocate too little storage for
"struct cr_panel *crp" in cr_backlight_probe().

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Cc: Thomas Hellstrom <thomas@tungstengraphics.com>
Cc: Alan Hourihane <alanh@tungstengraphics.com>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/video/backlight/cr_bllcd.c

index e9bbc3455c94d5ff8c02b7f05cdbd24df46f22be..1b3f6586bc9f433295ccee5bf5c32d5868e6d461 100644 (file)
@@ -174,7 +174,7 @@ static int cr_backlight_probe(struct platform_device *pdev)
        struct cr_panel *crp;
        u8 dev_en;
 
-       crp = kzalloc(sizeof(crp), GFP_KERNEL);
+       crp = kzalloc(sizeof(*crp), GFP_KERNEL);
        if (crp == NULL)
                return -ENOMEM;