]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[ARM] CATS: Do not try and map bad PCI IRQ numbers
authorBen Dooks <ben-linux@fluff.org>
Fri, 8 Aug 2008 20:22:35 +0000 (21:22 +0100)
committerBen Dooks <ben-linux@fluff.org>
Sat, 9 Aug 2008 12:51:53 +0000 (13:51 +0100)
The cats_map_irq() function in the Simtec CATS support
code is mapping IRQ 255 (invalid IRQ) into what is a
supposedly valid interrupt numner which can cause problems
with other devices then seeing an interrupt they cannot
claim.

If the IRQ number if >= 255, then return -1 as this is not
something we can map.

Signed-off-by: Ben Dooks <ben-linux@fluff.org>
arch/arm/mach-footbridge/cats-pci.c

index 35eb232a649a2b11aae684fdc169e3cf69fcefd2..ae3e1c8c75832419fd070d6f53a3c16db5a6c5c7 100644 (file)
@@ -18,6 +18,9 @@ static int irqmap_cats[] __initdata = { IRQ_PCI, IRQ_IN0, IRQ_IN1, IRQ_IN3 };
 
 static int __init cats_map_irq(struct pci_dev *dev, u8 slot, u8 pin)
 {
+       if (dev->irq >= 255)
+               return -1;      /* not a valid interrupt. */
+
        if (dev->irq >= 128)
                return dev->irq & 0x1f;