[NETFILTER]: nfnetlink: support attribute policies

Add support for automatic checking of per-callback attribute policies.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/include/linux/netfilter/nfnetlink.h b/include/linux/netfilter/nfnetlink.h
index e61a8a5fcaff2eba70231ea088dc6d8b0900fe22..cd8fded3655010d6ee13db8328b1665ad7ece642 100644 (file)
--- a/include/linux/netfilter/nfnetlink.h
+++ b/include/linux/netfilter/nfnetlink.h
@@ -58,7 +58,8 @@ struct nfnl_callback
 {
        int (*call)(struct sock *nl, struct sk_buff *skb, 
                struct nlmsghdr *nlh, struct nlattr *cda[]);
-       u_int16_t attr_count;   /* number of nlattr's */
+       const struct nla_policy *policy;        /* netlink attribute policy */
+       const u_int16_t attr_count;             /* number of nlattr's */
 };
 
 struct nfnetlink_subsystem

diff --git a/net/netfilter/nfnetlink.c b/net/netfilter/nfnetlink.c
index e212102b0e4ada1bc552b546fa4481c9a38104eb..cb41990f92e0d9fbd5f97e80f5353e6ca6c81dd2 100644 (file)
--- a/net/netfilter/nfnetlink.c
+++ b/net/netfilter/nfnetlink.c
@@ -111,35 +111,6 @@ nfnetlink_find_client(u_int16_t type, const struct nfnetlink_subsystem *ss)
        return &ss->cb[cb_id];
 }
 
-/**
- * nfnetlink_check_attributes - check and parse nfnetlink attributes
- *
- * subsys: nfnl subsystem for which this message is to be parsed
- * nlmsghdr: netlink message to be checked/parsed
- * cda: array of pointers, needs to be at least subsys->attr_count+1 big
- *
- */
-static int
-nfnetlink_check_attributes(const struct nfnetlink_subsystem *subsys,
-                          struct nlmsghdr *nlh, struct nlattr *cda[])
-{
-       int min_len = NLMSG_SPACE(sizeof(struct nfgenmsg));
-       u_int8_t cb_id = NFNL_MSG_TYPE(nlh->nlmsg_type);
-       u_int16_t attr_count = subsys->cb[cb_id].attr_count;
-
-       /* check attribute lengths. */
-       if (likely(nlh->nlmsg_len > min_len)) {
-               struct nlattr *attr = (void *)nlh + NLMSG_ALIGN(min_len);
-               int attrlen = nlh->nlmsg_len - NLMSG_ALIGN(min_len);
-               nla_parse(cda, attr_count, attr, attrlen, NULL);
-       }
-
-       /* implicit: if nlmsg_len == min_len, we return 0, and an empty
-        * (zeroed) cda[] array. The message is valid, but empty. */
-
-       return 0;
-}
-
 int nfnetlink_has_listeners(unsigned int group)
 {
        return netlink_has_listeners(nfnl, group);
@@ -192,15 +163,22 @@ static int nfnetlink_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
                return -EINVAL;
 
        {
-               u_int16_t attr_count =
-                       ss->cb[NFNL_MSG_TYPE(nlh->nlmsg_type)].attr_count;
+               int min_len = NLMSG_SPACE(sizeof(struct nfgenmsg));
+               u_int8_t cb_id = NFNL_MSG_TYPE(nlh->nlmsg_type);
+               u_int16_t attr_count = ss->cb[cb_id].attr_count;
                struct nlattr *cda[attr_count+1];
 
-               memset(cda, 0, sizeof(struct nlattr *) * attr_count);
+               if (likely(nlh->nlmsg_len >= min_len)) {
+                       struct nlattr *attr = (void *)nlh + NLMSG_ALIGN(min_len);
+                       int attrlen = nlh->nlmsg_len - NLMSG_ALIGN(min_len);
+
+                       err = nla_parse(cda, attr_count, attr, attrlen,
+                                       ss->cb[cb_id].policy);
+                       if (err < 0)
+                               return err;
+               } else
+                       return -EINVAL;
 
-               err = nfnetlink_check_attributes(ss, nlh, cda);
-               if (err < 0)
-                       return err;
                return nc->call(nfnl, skb, nlh, cda);
        }
 }