]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[ROSE]: Fix missing unlocks in rose_route_frame()
authorDavid S. Miller <davem@davemloft.net>
Tue, 23 Aug 2005 17:50:09 +0000 (10:50 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 23 Aug 2005 17:50:09 +0000 (10:50 -0700)
Noticed by Coverity checker.

Signed-off-by: David S. Miller <davem@davemloft.net>
net/rose/rose_route.c

index ff73ebb912b8ebd0f6887bdb776caa25922d9b5a..46b23217a35309ac60e2ae33d5d054faef5dd1ef 100644 (file)
@@ -994,8 +994,10 @@ int rose_route_frame(struct sk_buff *skb, ax25_cb *ax25)
         *      1. The frame isn't for us,
         *      2. It isn't "owned" by any existing route.
         */
-       if (frametype != ROSE_CALL_REQUEST)     /* XXX */
-               return 0;
+       if (frametype != ROSE_CALL_REQUEST) {   /* XXX */
+               ret = 0;
+               goto out;
+       }
 
        len  = (((skb->data[3] >> 4) & 0x0F) + 1) / 2;
        len += (((skb->data[3] >> 0) & 0x0F) + 1) / 2;