]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[XFS] Warn if errors come from block_truncate_page().
authorDavid Chinner <dgc@sgi.com>
Thu, 10 Apr 2008 02:21:46 +0000 (12:21 +1000)
committerLachlan McIlroy <lachlan@redback.melbourne.sgi.com>
Fri, 18 Apr 2008 01:59:12 +0000 (11:59 +1000)
block_truncate_page() can return errors that we currently ignore and
silently discard. We should not ever get errors reported here - an error
indicates a bug somewhere else. Hence catch the error and issue a stack
dump to the syslog because we cannot propagate the error any further up
the call chain.

SGI-PV: 980084
SGI-Modid: xfs-linux-melb:xfs-kern:30800a

Signed-off-by: David Chinner <dgc@sgi.com>
Signed-off-by: Niv Sardi <xaiki@sgi.com>
Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
fs/xfs/linux-2.6/xfs_iops.c

index 53f8feb28e585219e7be707c61907a530ed29f33..41e7baabfd9f1ca24d03051c74259d3c05f09fb9 100644 (file)
@@ -692,11 +692,19 @@ xfs_vn_setattr(
        return -error;
 }
 
+/*
+ * block_truncate_page can return an error, but we can't propagate it
+ * at all here. Leave a complaint + stack trace in the syslog because
+ * this could be bad. If it is bad, we need to propagate the error further.
+ */
 STATIC void
 xfs_vn_truncate(
        struct inode    *inode)
 {
-       block_truncate_page(inode->i_mapping, inode->i_size, xfs_get_blocks);
+       int     error;
+       error = block_truncate_page(inode->i_mapping, inode->i_size,
+                                                       xfs_get_blocks);
+       WARN_ON(error);
 }
 
 STATIC int