]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[NET]: Fix logical error in skb_gso_ok
authorHerbert Xu <herbert@gondor.apana.org.au>
Thu, 29 Jun 2006 19:25:53 +0000 (12:25 -0700)
committerDavid S. Miller <davem@sunset.davemloft.net>
Thu, 29 Jun 2006 23:58:04 +0000 (16:58 -0700)
The test in skb_gso_ok is backwards.  Noticed by Michael Chan
<mchan@broadcom.com>.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Acked-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/netdevice.h

index 84b0f0d16fcbd0166b92c7088a7d7c135ea82ed7..efd1e2af0bf32ce4d09bcb28f64b4a4621edd172 100644 (file)
@@ -994,12 +994,12 @@ static inline int skb_gso_ok(struct sk_buff *skb, int features)
 {
        int feature = skb_shinfo(skb)->gso_size ?
                      skb_shinfo(skb)->gso_type << NETIF_F_GSO_SHIFT : 0;
-       return (features & feature) != feature;
+       return (features & feature) == feature;
 }
 
 static inline int netif_needs_gso(struct net_device *dev, struct sk_buff *skb)
 {
-       return skb_gso_ok(skb, dev->features);
+       return !skb_gso_ok(skb, dev->features);
 }
 
 #endif /* __KERNEL__ */