]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
USB: Fix debugfs_create_file's error checking method for usb/gadget/s3c2410_udc
authorZhaolei <zhaolei@cn.fujitsu.com>
Mon, 20 Oct 2008 10:53:04 +0000 (18:53 +0800)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 22 Oct 2008 17:05:27 +0000 (10:05 -0700)
debugfs_create_file() returns NULL if an error occurs, returns -ENODEV
when debugfs is not enabled in the kernel.

Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/gadget/s3c2410_udc.c

index 48f51b12d2e21010140448a23b554cc5ee31a145..00ba06b4475204012498cfdd5028ce03556be948 100644 (file)
@@ -1894,11 +1894,8 @@ static int s3c2410_udc_probe(struct platform_device *pdev)
                udc->regs_info = debugfs_create_file("registers", S_IRUGO,
                                s3c2410_udc_debugfs_root,
                                udc, &s3c2410_udc_debugfs_fops);
-               if (IS_ERR(udc->regs_info)) {
-                       dev_warn(dev, "debugfs file creation failed %ld\n",
-                                PTR_ERR(udc->regs_info));
-                       udc->regs_info = NULL;
-               }
+               if (!udc->regs_info)
+                       dev_warn(dev, "debugfs file creation failed\n");
        }
 
        dev_dbg(dev, "probe ok\n");