]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[XFS] Use the incore inode size in xfs_file_readdir()
authorLachlan McIlroy <lachlan@redback.melbourne.sgi.com>
Mon, 22 Dec 2008 06:50:56 +0000 (17:50 +1100)
committerLachlan McIlroy <lachlan@redback.melbourne.sgi.com>
Mon, 22 Dec 2008 06:50:56 +0000 (17:50 +1100)
We should be using the incore inode size here not the linux inode
size.  The incore inode size is always up to date for directories
whereas the linux inode size is not updated for directories.

We've hit assertions in xfs_bmap() and traced it back to the linux
inode size being zero but the incore size being correct.

Reviewed-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
fs/xfs/linux-2.6/xfs_file.c

index a0c45cc8a6b8e852b591477e716fd0a4571dfb73..e14c4e3aea0c331f67ba529946e201c6d814e8ce 100644 (file)
@@ -204,7 +204,7 @@ xfs_file_readdir(
         * point we can change the ->readdir prototype to include the
         * buffer size.
         */
-       bufsize = (size_t)min_t(loff_t, PAGE_SIZE, inode->i_size);
+       bufsize = (size_t)min_t(loff_t, PAGE_SIZE, ip->i_d.di_size);
 
        error = xfs_readdir(ip, dirent, bufsize,
                                (xfs_off_t *)&filp->f_pos, filldir);