]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
pata_pcmcia: Fix oops in 2.6.21-rc1
authorAlan <alan@lxorguk.ukuu.org.uk>
Wed, 21 Feb 2007 16:41:23 +0000 (16:41 +0000)
committerJeff Garzik <jeff@garzik.org>
Sun, 25 Feb 2007 20:41:40 +0000 (15:41 -0500)
Manuel Lass reports:
> This bug is also present in 2.6.21-rc1, and this patch
> indeed fixes it.

The change to the devres layer re-orders the execution of cleanup
functions and in turn causes the pcmcia layer to oops as it zaps a
pointer now needed later on. We simply leave the pointer alone.

Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/ata/pata_pcmcia.c

index d10ae3e7224586c48fef433b7c66c836c9d453a5..4ef477c12036cbfdddc6a1df0e8e9df5a5cced9d 100644 (file)
@@ -308,7 +308,6 @@ static void pcmcia_remove_one(struct pcmcia_device *pdev)
                if (info->ndev) {
                        struct ata_host *host = dev_get_drvdata(dev);
                        ata_host_detach(host);
-                       dev_set_drvdata(dev, NULL);
                }
                info->ndev = 0;
                pdev->priv = NULL;