]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[SPARC64]: Disable preemption during flush_tlb_pending().
authorDavid S. Miller <davem@sunset.davemloft.net>
Mon, 1 May 2006 05:54:27 +0000 (22:54 -0700)
committerDavid S. Miller <davem@sunset.davemloft.net>
Mon, 1 May 2006 05:54:27 +0000 (22:54 -0700)
A context switch will force a call to flush_tlb_pending() (via
switch_to()), so if we test tlb_nr to be non-zero, then sleep, it
would become zero and later back at the original context we'll pass
zero down into the TLB flushing code which should never see a nr
argument of zero.

Signed-off-by: David S. Miller <davem@davemloft.net>
arch/sparc64/mm/tlb.c

index a079cf42505ed08906d42b0371372d6842d8a8b7..3f10fc921b00e1bfb6279f8ccf00986ad7619089 100644 (file)
@@ -8,6 +8,7 @@
 #include <linux/percpu.h>
 #include <linux/mm.h>
 #include <linux/swap.h>
+#include <linux/preempt.h>
 
 #include <asm/pgtable.h>
 #include <asm/pgalloc.h>
@@ -24,6 +25,8 @@ void flush_tlb_pending(void)
 {
        struct mmu_gather *mp = &__get_cpu_var(mmu_gathers);
 
+       preempt_disable();
+
        if (mp->tlb_nr) {
                flush_tsb_user(mp);
 
@@ -38,6 +41,8 @@ void flush_tlb_pending(void)
                }
                mp->tlb_nr = 0;
        }
+
+       preempt_enable();
 }
 
 void tlb_batch_add(struct mm_struct *mm, unsigned long vaddr, pte_t *ptep, pte_t orig)