]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
drm: reorder struct drm_ioctl_desc to save space on 64 bit builds
authorRichard Kennedy <richard@rsk.demon.co.uk>
Wed, 18 Mar 2009 17:26:44 +0000 (17:26 +0000)
committerDave Airlie <airlied@redhat.com>
Sun, 29 Mar 2009 08:31:45 +0000 (18:31 +1000)
shrinks drm_ioctl_desc from 24 bytes to 16 bytes by reordering members
to remove padding.

updates DRM_IOCTL_DEF macro to initialise structure members by name to
handle the structure reorder.

The applied patch reduces data used in drm.ko from 10440 to 9032

Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
Signed-off-by: Dave Airlie <airlied@redhat.com>
include/drm/drmP.h

index ccbcd13b6ed389e5c251d7f62d22dc8ded7ebd9a..c8c42215143158ef6eed2d5bcb9a00f42f29a857 100644 (file)
@@ -281,16 +281,16 @@ typedef int drm_ioctl_compat_t(struct file *filp, unsigned int cmd,
 
 struct drm_ioctl_desc {
        unsigned int cmd;
-       drm_ioctl_t *func;
        int flags;
+       drm_ioctl_t *func;
 };
 
 /**
  * Creates a driver or general drm_ioctl_desc array entry for the given
  * ioctl, for use by drm_ioctl().
  */
-#define DRM_IOCTL_DEF(ioctl, func, flags) \
-       [DRM_IOCTL_NR(ioctl)] = {ioctl, func, flags}
+#define DRM_IOCTL_DEF(ioctl, _func, _flags) \
+       [DRM_IOCTL_NR(ioctl)] = {.cmd = ioctl, .func = _func, .flags = _flags}
 
 struct drm_magic_entry {
        struct list_head head;