]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
x25: Use sock_orphan() instead of open-coded (and buggy) variant.
authorDavid S. Miller <davem@davemloft.net>
Tue, 17 Jun 2008 10:05:13 +0000 (03:05 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 17 Jun 2008 10:05:13 +0000 (03:05 -0700)
It doesn't grab the sk_callback_lock, it doesn't NULL out
the sk->sk_sleep waitqueue pointer, etc.

Signed-off-by: David S. Miller <davem@davemloft.net>
net/x25/af_x25.c

index bcb091f713ec0899a07bde24c722d32d22c3baa2..7b1c6ef04553602fdb156727e9bd10f8531b88d6 100644 (file)
@@ -612,8 +612,7 @@ static int x25_release(struct socket *sock)
                        break;
        }
 
-       sock->sk        = NULL;
-       sk->sk_socket   = NULL; /* Not used, but we should do this */
+       sock_orphan(sk);
 out:
        return 0;
 }