]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
V4L/DVB (9623): tvaudio: Improve debug msg by printing something more human
authorMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 13 Nov 2008 21:12:43 +0000 (18:12 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Fri, 14 Nov 2008 16:24:45 +0000 (14:24 -0200)
Before the patch, the used ioctl were printed as an hexadecimal code,
hard to be understand without consulting the way _IO macros work.
Instead, use the V4L default handler for printing such errors into a way
that would be easier to understand.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/tvaudio.c

index 779ce7f865c373a5b18ee5c41ba87ea3ee6b41b6..fb46ce4a1090a8fdfafe795f029615c101cc045c 100644 (file)
@@ -34,6 +34,7 @@
 
 #include <media/tvaudio.h>
 #include <media/v4l2-common.h>
+#include <media/v4l2-ioctl.h>
 #include <media/v4l2-chip-ident.h>
 #include <media/v4l2-i2c-drv-legacy.h>
 
@@ -1732,7 +1733,10 @@ static int chip_command(struct i2c_client *client,
        struct CHIPSTATE *chip = i2c_get_clientdata(client);
        struct CHIPDESC  *desc = chip->desc;
 
-       v4l_dbg(1, debug, chip->c, "%s: chip_command 0x%x\n", chip->c->name, cmd);
+       if (debug > 0) {
+               v4l_i2c_print_ioctl(chip->c, cmd);
+               printk("\n");
+       }
 
        switch (cmd) {
        case AUDC_SET_RADIO: