]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[COMPAT]: Fix new dev_ifname32 returning -EFAULT
authorBenjamin Herrenschmidt <benh@kernel.crashing.org>
Wed, 31 Oct 2007 03:40:45 +0000 (20:40 -0700)
committerDavid S. Miller <davem@sunset.davemloft.net>
Wed, 31 Oct 2007 04:29:42 +0000 (21:29 -0700)
A stray semicolon slipped in the patch that updated dev_ifname32 to
not be inline, causing it to always return -EFAULT. This fixes it.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
fs/compat_ioctl.c

index a4284ccac1f98a41becf824a638819222e1b5ae0..bd26e4cbb994f810b0ce8dc8ce3780356e0f66fa 100644 (file)
@@ -322,7 +322,7 @@ static int dev_ifname32(unsigned int fd, unsigned int cmd, unsigned long arg)
        int err;
 
        uifr = compat_alloc_user_space(sizeof(struct ifreq));
-       if (copy_in_user(uifr, compat_ptr(arg), sizeof(struct ifreq32)));
+       if (copy_in_user(uifr, compat_ptr(arg), sizeof(struct ifreq32)))
                return -EFAULT;
 
        err = sys_ioctl(fd, SIOCGIFNAME, (unsigned long)uifr);