]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[POWERPC] Various fixes to pcibios_enable_device()
authorBenjamin Herrenschmidt <benh@kernel.crashing.org>
Thu, 20 Dec 2007 03:55:00 +0000 (14:55 +1100)
committerPaul Mackerras <paulus@samba.org>
Thu, 20 Dec 2007 05:18:13 +0000 (16:18 +1100)
Our implementation of pcibios_enable_device() has a couple of problems.

One is that it should not check IORESOURCE_UNSET, as this might be
left dangling after resource assignment (shouldn't but there are
bugs), but instead, we make it check resource->parent which should
be a reliable indication that the resource has been successfully
claimed (it's in the resource tree).

Then, we also need to skip ROM resources that haven't been enabled
as x86 does.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>
arch/powerpc/kernel/pci-common.c

index 8935661d12d039f6bd8b161c21ce91e819526429..b6d4767e4e27419b67ea12014a769c39855185e2 100644 (file)
@@ -1147,7 +1147,10 @@ int pcibios_enable_device(struct pci_dev *dev, int mask)
                r = &dev->resource[idx];
                if (!(r->flags & (IORESOURCE_IO | IORESOURCE_MEM)))
                        continue;
-               if (r->flags & IORESOURCE_UNSET) {
+               if ((idx == PCI_ROM_RESOURCE) &&
+                               (!(r->flags & IORESOURCE_ROM_ENABLE)))
+                       continue;
+               if (r->parent == NULL) {
                        printk(KERN_ERR "PCI: Device %s not available because"
                               " of resource collisions\n", pci_name(dev));
                        return -EINVAL;