]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[IPV6]: fix lockup via /proc/net/ip6_flowlabel
authorJames Morris <jmorris@namei.org>
Mon, 30 Oct 2006 23:08:42 +0000 (15:08 -0800)
committerDavid S. Miller <davem@sunset.davemloft.net>
Mon, 30 Oct 2006 23:24:42 +0000 (15:24 -0800)
There's a bug in the seqfile handling for /proc/net/ip6_flowlabel, where,
after finding a flowlabel, the code will loop forever not finding any
further flowlabels, first traversing the rest of the hash bucket then just
looping.

This patch fixes the problem by breaking after the hash bucket has been
traversed.

Note that this bug can cause lockups and oopses, and is trivially invoked
by an unpriveleged user.

Signed-off-by: James Morris <jmorris@namei.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/ip6_flowlabel.c

index 1d672b0547f25c9bed0fcb72a2125bc0b475c857..062e526a668c511406ceeeec85fb379b52cfc568 100644 (file)
@@ -587,6 +587,8 @@ static struct ip6_flowlabel *ip6fl_get_next(struct seq_file *seq, struct ip6_flo
        while (!fl) {
                if (++state->bucket <= FL_HASH_MASK)
                        fl = fl_ht[state->bucket];
+               else
+                       break;
        }
        return fl;
 }