]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
de2104x: force correct order when writing to rx ring
authorRisto Suominen <Risto.Suominen@gmail.com>
Mon, 9 Feb 2009 01:50:34 +0000 (17:50 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 9 Feb 2009 01:50:34 +0000 (17:50 -0800)
DescOwn should not be set, thus allowing the chip to use the
descriptor, before everything else is set up correctly.

Signed-off-by: Risto Suominen <Risto.Suominen@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/tulip/de2104x.c

index 0bf2114738bea563192d58bec9c9347b43112516..d4c5ecc51f779e975eff00a72413a46ae4c171b2 100644 (file)
@@ -464,13 +464,14 @@ static void de_rx (struct de_private *de)
                        drop = 1;
 
 rx_next:
-               de->rx_ring[rx_tail].opts1 = cpu_to_le32(DescOwn);
                if (rx_tail == (DE_RX_RING_SIZE - 1))
                        de->rx_ring[rx_tail].opts2 =
                                cpu_to_le32(RingEnd | de->rx_buf_sz);
                else
                        de->rx_ring[rx_tail].opts2 = cpu_to_le32(de->rx_buf_sz);
                de->rx_ring[rx_tail].addr1 = cpu_to_le32(mapping);
+               wmb();
+               de->rx_ring[rx_tail].opts1 = cpu_to_le32(DescOwn);
                rx_tail = NEXT_RX(rx_tail);
        }