]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
IB/ehca: Fix static rate if path faster than link
authorJoachim Fenkes <fenkes@de.ibm.com>
Sat, 1 Dec 2007 00:19:41 +0000 (16:19 -0800)
committerRoland Dreier <rolandd@cisco.com>
Sat, 1 Dec 2007 00:19:41 +0000 (16:19 -0800)
The formula would yield -1 if the path is faster than the link, which
is wrong in a bad way (max throttling).  Clamp to 0, which is the
correct value.

Signed-off-by: Joachim Fenkes <fenkes@de.ibm.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
drivers/infiniband/hw/ehca/ehca_av.c

index 453eb995c1d47b59255e46d4fcad70147d83c9e5..f7782c882ab4c9cfb9c6c49ee116efb1107f639d 100644 (file)
@@ -76,8 +76,12 @@ int ehca_calc_ipd(struct ehca_shca *shca, int port,
 
        link = ib_width_enum_to_int(pa.active_width) * pa.active_speed;
 
-       /* IPD = round((link / path) - 1) */
-       *ipd = ((link + (path >> 1)) / path) - 1;
+       if (path >= link)
+               /* no need to throttle if path faster than link */
+               *ipd = 0;
+       else
+               /* IPD = round((link / path) - 1) */
+               *ipd = ((link + (path >> 1)) / path) - 1;
 
        return 0;
 }