]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
firewire: ohci: change "context_stop: still active" log message
authorStefan Richter <stefanr@s5r6.in-berlin.de>
Mon, 5 Jan 2009 19:43:23 +0000 (20:43 +0100)
committerStefan Richter <stefanr@s5r6.in-berlin.de>
Sat, 24 Jan 2009 10:17:27 +0000 (11:17 +0100)
The present message is mostly just noise.  We only need to be notified
if the "active" flag does not go off before the retry loop terminates.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
drivers/firewire/fw-ohci.c

index ab9c01e462ef64a197c72250fed471b361477f02..9bedd6159f2871a305e355fb76701572a1a2c6d6 100644 (file)
@@ -896,11 +896,11 @@ static void context_stop(struct context *ctx)
        for (i = 0; i < 10; i++) {
                reg = reg_read(ctx->ohci, CONTROL_SET(ctx->regs));
                if ((reg & CONTEXT_ACTIVE) == 0)
-                       break;
+                       return;
 
-               fw_notify("context_stop: still active (0x%08x)\n", reg);
                mdelay(1);
        }
+       fw_error("Error: DMA context still active (0x%08x)\n", reg);
 }
 
 struct driver_data {