]> pilppa.com Git - linux-2.6-omap-h63xx.git/commitdiff
[POWERPC] arch/powerpc: Add missing of_node_put
authorJulia Lawall <julia@diku.dk>
Thu, 13 Dec 2007 23:56:15 +0000 (15:56 -0800)
committerPaul Mackerras <paulus@samba.org>
Thu, 20 Dec 2007 06:13:51 +0000 (17:13 +1100)
There should be an of_node_put when breaking out of a loop that iterates
over calls to of_find_all_nodes, as this function does an of_node_get on
the value it returns.

This was fixed using the following semantic patch.
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
type T;
identifier d;
expression e;
@@

T *d;
...
for (d = NULL; (d = of_find_all_nodes(d)) != NULL; )
 {... when != of_node_put(d)
      when != e = d
(
   return d;
|
+  of_node_put(d);
?  return ...;
)
...}
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>
arch/powerpc/platforms/iseries/iommu.c

index 49e9c664ea89b0745829dfd52058f620b35fdb27..6a0c6f6675cdf0d3dce57eda11ae7009ebb77e58 100644 (file)
@@ -163,8 +163,10 @@ static struct iommu_table *iommu_table_find(struct iommu_table * tbl)
                    (it->it_type == TCE_PCI) &&
                    (it->it_offset == tbl->it_offset) &&
                    (it->it_index == tbl->it_index) &&
-                   (it->it_size == tbl->it_size))
+                   (it->it_size == tbl->it_size)) {
+                       of_node_put(node);
                        return it;
+               }
        }
        return NULL;
 }